Pass additional options to JVM (WIP) #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
reviewed
Oct 2, 2024
| - "/usr/lib/trino/gateway-ha-jar-with-dependencies.jar" | ||
| - "/etc/gateway/config.yaml" | ||
| - java | ||
| {{- toYaml append .Values.javaOptions list "-XX:MinRAMPercentage=80.0" "-XX:MaxRAMPercentage=80.0" "-jar" "/usr/lib/trino/gateway-ha-jar-with-dependencies.jar" "/etc/gateway/config.yaml"}} |
There was a problem hiding this comment.
How about moving the options all into the values file
There was a problem hiding this comment.
In this setup you cant really override those values right? Or at least they would show up twice..
There was a problem hiding this comment.
that could be nice and simple, i'll update this
willmostly
changed the title
willmostly
force-pushed
the
will/helm-jvm-opts
branch
from
e0f8f4f
to
9f684c1
Compare
mosabua
reviewed
Oct 3, 2024
| @@ -52,6 +52,15 @@ config: | |||
| managedApps: | |||
| - io.trino.gateway.ha.clustermonitor.ActiveClusterMonitor | |||
|
|
|||
| # Startup command for Trino Gateway process. Add additional java options here if required | |||
| command: | |||
| - "java" | |||
There was a problem hiding this comment.
two space indent like in below or four like above.. maybe we should make the whole file consistent
|
If we go with this approach where the whole command is configurable.. which is fine by me .. we should update commit message, PR name, release notes suggestion, and also add relevant info to the docs. |
mosabua
requested changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow passing additional java options to the startup command
Additional context and related issues
Users may need to set additional java options, e.g. using
-Djavax.net.ssl.truststore=/path/to/truststorein combination with a volume for mounting a certificate bundle.Release notes
required.
Helm Chart
Allow passing additional java options to the startup command